Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional Gradle plugin tasks initialization #298

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

ileasile
Copy link
Contributor

@ileasile ileasile commented Jul 7, 2021

Fixes #255
@altavir could you please review and test it with your project(s)? I'll send you a plugin version to use.

@ileasile ileasile force-pushed the fix-gradle-plugin-255 branch from 7e43483 to 2c39132 Compare July 7, 2021 02:55
@altavir
Copy link
Contributor

altavir commented Jul 7, 2021

OK. I think I can build it myself since it seems like a regular jar.

I do not have problems in my projects even with the old plugin because I define kotlin platforms in the plugin application block (so it is before the jupyter plugin). The problem appeared when I tried to demonstrate a stand-alone plugin.

@ileasile ileasile requested a review from altavir July 7, 2021 07:48
@ileasile
Copy link
Contributor Author

ileasile commented Jul 7, 2021

@altavir you may try version 0.10.0-94-1

@ileasile ileasile force-pushed the fix-gradle-plugin-255 branch from 2c39132 to e7acb11 Compare July 7, 2021 09:53
@ileasile ileasile force-pushed the fix-gradle-plugin-255 branch from e7acb11 to dede7ce Compare July 7, 2021 10:27
@ileasile ileasile merged commit d220303 into master Jul 7, 2021
@ileasile ileasile deleted the fix-gradle-plugin-255 branch July 14, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Gradle plugin for Multiplatform project
2 participants